Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix osmo dep version #696

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: fix osmo dep version #696

merged 2 commits into from
Mar 21, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Mar 20, 2024

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt requested a review from a team as a code owner March 20, 2024 10:49
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.37%. Comparing base (657138c) to head (4f21efb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   30.37%   30.37%           
=======================================
  Files         233      233           
  Lines       32579    32579           
=======================================
  Hits         9897     9897           
  Misses      21127    21127           
  Partials     1555     1555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtsitrin
mtsitrin previously approved these changes Mar 20, 2024
@omritoptix
Copy link
Contributor

@danwt conflict with main

@danwt
Copy link
Contributor Author

danwt commented Mar 20, 2024

@danwt conflict with main

fixed now

@danwt danwt requested a review from mtsitrin March 20, 2024 11:28
@mtsitrin mtsitrin requested a review from omritoptix March 20, 2024 11:38
@omritoptix omritoptix merged commit 067a132 into main Mar 21, 2024
13 checks passed
@omritoptix omritoptix deleted the feature/use-osmosis-15p2p1 branch March 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants