feat!: switch the proposing sequencer after unbonding #606
Conversation
This reverts commit c808d79.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 30.41% 30.46% +0.04%
==========================================
Files 201 201
Lines 28451 28514 +63
==========================================
+ Hits 8654 8687 +33
- Misses 18449 18474 +25
- Partials 1348 1353 +5 ☔ View full report in Codecov by Sentry. |
|
@mtsitrin tests failed |
mtsitrin
changed the title
| } | ||
| */ | ||
| } | ||
| if !proposerFound { |
There was a problem hiding this comment.
not sure it's a invariant break. we can have a frozen rollapp or a rollapp with no active sequencer which is waiting for a sequencer to come up. we can't force a rollapp to have a proposer - e.g if a proposer is unbonding and don't want to propose anymore or it's jailed.
There was a problem hiding this comment.
we have
if len(bonded) == 0 {
continue
}
So if there are bonded sequencers, i would expect a proposer one
| func (k Keeper) RotateProposer(ctx sdk.Context, rollappId string) { | ||
| seqsByRollapp := k.GetSequencersByRollappByStatus(ctx, rollappId, types.Bonded) | ||
| if len(seqsByRollapp) == 0 { | ||
| k.Logger(ctx).Error("no bonded sequencer found for rollapp", "rollappId", rollappId) |
There was a problem hiding this comment.
not sure it's an error. as I see it's a valid world state.
There was a problem hiding this comment.
right. will change in upcoming PR
mtsitrin
deleted the
mtsitrin/605-switch-the-proposing-sequencer-after-unbonding
branch
Description
Closes #605
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
---;
After reviewer approval: