fix(rollapp liveness): rename last state update height to liveness co…

…untdown start height (#1512)

app/upgrades/v4/upgrade.go

@@ -354,13 +354,13 @@ func ConvertOldRollappToNew(oldRollapp rollapptypes.Rollapp) rollapptypes.Rollap
 			Tagline:     "",
 			FeeDenom:    nil,
 		},
-		GenesisInfo:           genesisInfo,
-		InitialSequencer:      "*",
-		VmType:                rollapptypes.Rollapp_EVM, // EVM for existing rollapps
-		Launched:              true,                     // Existing rollapps are already launched
-		PreLaunchTime:         nil,                      // We can just let it be zero. Existing rollapps are already launched.
-		LivenessEventHeight:   0,                        // Filled lazily in runtime
-		LastStateUpdateHeight: 0,                        // Filled lazily in runtime
+		GenesisInfo:                  genesisInfo,
+		InitialSequencer:             "*",
+		VmType:                       rollapptypes.Rollapp_EVM, // EVM for existing rollapps
+		Launched:                     true,                     // Existing rollapps are already launched
+		PreLaunchTime:                nil,                      // We can just let it be zero. Existing rollapps are already launched.
+		LivenessEventHeight:          0,                        // Filled lazily in runtime
+		LivenessCountdownStartHeight: 0,                        // Filled lazily in runtime
 		Revisions: []rollapptypes.Revision{{
 			Number:      0,
 			StartHeight: 0,

proto/dymensionxyz/dymension/rollapp/rollapp.proto

@@ -71,9 +71,9 @@ message Rollapp {
   // LivenessEventHeight is the height on the HUB of an upcoming liveness event (slash or
   // jail against the rollapp). 0 means not set
   int64 liveness_event_height = 17;
-  // The LastStateUpdateHeight HUB height when the last state update was
-  // received
-  int64 last_state_update_height = 18;
+  // The height on the HUB that we start counting liveness from. If the rollapp is not active
+  // for a long time after this height, a liveness event will happen.
+  int64 liveness_countdown_start_height = 18;
 
   // Revisions is a list of all the rollapp revisions.
   repeated Revision revisions = 19 [ (gogoproto.nullable) = false ];

x/rollapp/keeper/liveness.go

@@ -79,7 +79,7 @@ func (k Keeper) IndicateLiveness(ctx sdk.Context, ra *types.Rollapp) {
 // Modifies the passed-in rollapp object.
 func (k Keeper) ResetLivenessClock(ctx sdk.Context, ra *types.Rollapp) {
 	k.DelLivenessEvents(ctx, ra.LivenessEventHeight, ra.RollappId)
-	ra.LastStateUpdateHeight = ctx.BlockHeight()
+	ra.LivenessCountdownStartHeight = ctx.BlockHeight()
 	ra.LivenessEventHeight = 0
 }
 
@@ -91,7 +91,7 @@ func (k Keeper) ScheduleLivenessEvent(ctx sdk.Context, ra *types.Rollapp) {
 		params.LivenessSlashBlocks,
 		params.LivenessSlashInterval,
 		ctx.BlockHeight(),
-		ra.LastStateUpdateHeight,
+		ra.LivenessCountdownStartHeight,
 	)
 	ra.LivenessEventHeight = nextH
 	k.PutLivenessEvent(ctx, types.LivenessEvent{