fix(light client): disable misbehavior update for canon client (#1212)

dymensionxyz · Sep 11, 2024 · 09f56ab · 09f56ab
1 parent 3fae9f1
commit 09f56ab
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 0 deletions.
diff --git a/x/lightclient/ante/ibc_msg_update_client.go b/x/lightclient/ante/ibc_msg_update_client.go
@@ -1,10 +1,12 @@
 package ante
 
 import (
+	errorsmod "cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	ibcclienttypes "github.com/cosmos/ibc-go/v7/modules/core/02-client/types"
 	ibctm "github.com/cosmos/ibc-go/v7/modules/light-clients/07-tendermint"
 	"github.com/dymensionxyz/dymension/v3/x/lightclient/types"
+	"github.com/dymensionxyz/gerr-cosmos/gerrc"
 )
 
 func (i IBCMessagesDecorator) HandleMsgUpdateClient(ctx sdk.Context, msg *ibcclienttypes.MsgUpdateClient) error {
@@ -23,10 +25,15 @@ func (i IBCMessagesDecorator) HandleMsgUpdateClient(ctx sdk.Context, msg *ibccli
 	if canonicalClient != msg.ClientId {
 		return nil // The client is not a rollapp's canonical client. Continue with default behaviour.
 	}
+
 	clientMessage, err := ibcclienttypes.UnpackClientMessage(msg.ClientMessage)
 	if err != nil {
 		return nil
 	}
+	_, ok = clientMessage.(*ibctm.Misbehaviour)
+	if ok {
+		return errorsmod.Wrap(gerrc.ErrFailedPrecondition, "misbehavior evidence is disabled for canonical clients")
+	}
 	header, ok := clientMessage.(*ibctm.Header)
 	if !ok {
 		return nil

diff --git a/x/lightclient/ante/ibc_msg_update_client_test.go b/x/lightclient/ante/ibc_msg_update_client_test.go
@@ -292,6 +292,42 @@ func TestHandleMsgUpdateClient(t *testing.T) {
 				require.NoError(t, err)
 			},
 		},
+		{
+			name: "Client is not a known canonical client of a rollapp",
+			prepare: func(ctx sdk.Context, k keeper.Keeper) testInput {
+				return testInput{
+					msg: &ibcclienttypes.MsgUpdateClient{
+						ClientId: "canon-client-id",
+					},
+				}
+			},
+			assert: func(ctx sdk.Context, k keeper.Keeper, err error) {
+				require.NoError(t, err)
+			},
+		},
+		{
+			name: "SubmitMisbehavior for a canonical chain",
+			prepare: func(ctx sdk.Context, k keeper.Keeper) testInput {
+				k.SetCanonicalClient(ctx, "rollapp-has-canon-client", "canon-client-id")
+				m := &ibctm.Misbehaviour{}
+				mAny, _ := ibcclienttypes.PackClientMessage(m)
+
+				return testInput{
+					msg: &ibcclienttypes.MsgUpdateClient{
+						ClientId:      "canon-client-id",
+						ClientMessage: mAny,
+					},
+					rollapps: map[string]rollapptypes.Rollapp{
+						"rollapp-has-canon-client": {
+							RollappId: "rollapp-has-canon-client",
+						},
+					},
+				}
+			},
+			assert: func(ctx sdk.Context, k keeper.Keeper, err error) {
+				require.Error(t, err)
+			},
+		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {