Fixes to Table model class
#199
Conversation
Make the limits immutable. Use the maximum limit constant `0x1_0000_0000` when the upper limit is unspecified, and simplify comparisons accordingly. There is a class which represents limits; change `Table` to reuse it.
| @@ -1,19 +1,31 @@ | |||
| package com.dylibso.chicory.wasm.types; | |||
|
|
|||
| public class Limits { | |||
| private final int min; | |||
| private final int max; | |||
| public static final long LIMIT_MAX = 0x1_0000_0000L; | |||
There was a problem hiding this comment.
I was wondering where this number comes from and I found this thread. Do you have a better link?
According to the follow up PR they are defining different limits for different things.
Should we specialize Limits for each usage?
Interested in hearing your reasoning around this 🙏
There was a problem hiding this comment.
Limits are used only where things are indexed by a 32-bit unsigned integer. Therefore "unlimited" is effectively the largest 32-bit unsigned integer plus one (because limits apply to sizes, not to indices).
There was a problem hiding this comment.
I think specializing limits might be a good idea, but I don't know if specializing it by type is necessarily the right thing, if we think of "limits" as a data structure.
We could possibly pursue that in a follow-up PR.
Make the limits immutable. Use the maximum limit constant
0x1_0000_0000when the upper limit is unspecified, and simplify comparisons accordingly. There is a class which represents limits; changeTableto reuse it.