Skip to content

fix(agent-runtime): three correctness bugs in adapter and legacy-bridge #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudiusthebot merged 1 commit into from
Jun 6, 2026
Merged

fix(agent-runtime): three correctness bugs in adapter and legacy-bridge #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/core/agent-runtime/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,17 +147,21 @@ export function adaptQueryBackend(
}
: undefined;

const sessions: SessionBackend | undefined =
legacy.resetChat || legacy.warmSession
? {
resetChat(chatId) {
return legacy.resetChat?.(chatId);
},
warmSession: legacy.warmSession
? (chatId) => legacy.warmSession!(chatId)
: undefined,
}
: undefined;
// Only advertise session support when resetChat is actually implemented.
// warmSession is a cold-start optimisation hint that can only be meaningful
// alongside reset support — advertising sessions: true with a no-op resetChat
// (because only warmSession was defined) misleads callers into believing they
// can reset the session when they actually cannot.
const sessions: SessionBackend | undefined = legacy.resetChat
? {
resetChat(chatId) {
return legacy.resetChat!(chatId);
},
warmSession: legacy.warmSession
? (chatId) => legacy.warmSession!(chatId)
: undefined,
}
: undefined;

const tools: ToolRuntime | undefined = legacy.refreshMcpServers
? {
Expand Down
28 changes: 22 additions & 6 deletions src/core/agent-runtime/legacy-bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,23 @@ export async function pipeEventsToCallbacks(
break;
}
case "tool_call": {
if (
!isPlainObject(event.input) &&
event.input !== undefined &&
event.input !== null
) {
// The legacy onToolUse contract requires Record<string, unknown>, so
// non-plain-object inputs (e.g. arrays emitted by Phase 3 backends)
// cannot be forwarded verbatim. Log the data loss so operators can
// diagnose if a tool receives empty args when it shouldn't.
const typeLabel = Array.isArray(event.input)
? "array"
: typeof event.input;
console.warn(
`[legacy-bridge] tool_call "${event.name}": input is ${typeLabel}, ` +
`not a plain object — bridging to {} (legacy onToolUse accepts only Record<string, unknown>).`,
);
}
const input = isPlainObject(event.input)
? (event.input as Record<string, unknown>)
: {};
Expand Down Expand Up @@ -178,7 +195,6 @@ export async function reduceEventsToResult(
let usage = emptyUsage();
let modelId: string | undefined;
let durationMs = 0;
let saw = false;

for await (const event of stream) {
switch (event.type) {
Expand All @@ -193,7 +209,6 @@ export async function reduceEventsToResult(
if (event.usage.modelId) modelId = event.usage.modelId;
break;
case "completed":
saw = true;
if (event.result) {
return event.result;
}
Expand All @@ -205,10 +220,11 @@ export async function reduceEventsToResult(
}
}

// No completed event seen — synthesise from observed deltas.
// Phase 3.x backends should always emit `completed`; falling
// through here means the stream ended on a non-terminator,
// which is a backend contract violation but not catastrophic.
// Stream ended without a `completed` terminator, OR the `completed`
// event carried no result. Phase 3.x backends should always emit
// `completed` with a result; falling through here means the stream
// ended on a non-terminator, which is a backend contract violation
// but not catastrophic — synthesise from observed deltas.
return {
text,
durationMs,
Expand Down
Loading