fix: three correctness bugs (withRetry delay, history log label, cron null-deref)

[dylanneve1]

Summary

Deep code review of the full repository surfaced three correctness bugs:

• src/core/gateway.ts — withRetry silently ignored rate-limit retry-after hints (HIGH)
  delayMs was computed from classified.retryAfterMs and logged, but p-retry's own minTimeout: 1000 / factor: 2 backoff was the actual wait — capping delays at 1–2 s regardless of what the API instructed (often 60 s for rate limits). Fixed by inserting await sleep(delayMs) before rethrowing and setting p-retry's own timeout to 0 to avoid double-waiting.

• src/storage/history.ts — wrong log label in corrupt-backup error path (LOW)
  loadHistory emitted logError("sessions", ...) instead of logError("history", ...) when both the primary store and its backup were unreadable — a copy-paste error from sessions.ts. Fixed.

• src/storage/cron-store.ts — unsafe Date cast on Cron#nextRun() (MEDIUM)
  validateCronExpression did (nextDate as Date).toISOString() without checking for null. Cron#nextRun() returns Date | null (e.g. for schedules whose window has already passed), so this throws a TypeError at runtime. Fixed with a null guard.

• src/__tests__/gateway-retry.test.ts — exhaustion tests had unhandled rejections
  The fake-timer approach (vi.useFakeTimers + vi.runAllTimersAsync) left p-retry's internal promise chains unsettled after assertions completed, producing 3 unhandled-rejection warnings and a non-zero Errors count in Vitest output. Replaced with retryAfterMs: 1 so real timers fire in ~1 ms — no fake timers needed.

Test plan

• npx vitest run src/__tests__/gateway-retry.test.ts — 26 tests pass, 0 errors
• Manual: trigger a rate-limited call and confirm the bot waits the full retry-after duration before retrying
• Manual: create a cron expression with no upcoming run dates and confirm /cron add returns a valid response rather than a 500

https://claude.ai/code/session_01ENgnJb7py1ZCKA9ET7EMxm

---

Generated by Claude Code

[claudiusthebot]

34/34 CI green ✅ — LGTM.

Three genuine correctness bugs, each cleanly fixed. A few notes on overlaps with older open PRs:

Bug 1 (withRetry) — also fixed in PR #162 Bug 1, using the differential approach (retryAfterMs - pRetryDelay). This PR's approach — set p-retry minTimeout: 0 and sleep the full delayMs before rethrowing — is arguably cleaner since it doesn't depend on knowing p-retry's internal backoff arithmetic. Either works; this is simpler. If this lands first, #162 will conflict on gateway.ts and will need to drop its Bug 1. Flagging on #162.

Bug 2 (history.ts log label) — same one-line fix as PR #168 Bug 1. No semantic conflict, just a mechanical rebase need.

Bug 3 (cron-store.ts null guard) — same fix as PR #168 Bug 7. Same story — clean but will require a rebase on #168.

The test cleanup (replacing fake timers + vi.runAllTimersAsync with retryAfterMs: 1 real timers) is the right call. Fake timers + p-retry's internal promise chains interact poorly; real 1ms sleeps sidestep the whole problem.

Impact on older PRs after this lands:

• #162: needs Bug 1 dropped (Bugs 2 + 3 — sticker rate-limit + chatId null check — remain unique and worth landing)
• #168: needs Bugs 1 + 7 dropped, then a rebase; Bugs 2–6 (5 bugs) remain unique

I'll note the overlap on both.

[dylanneve1]

Superseded by #246. I reviewed the old changes and ported the valid/current fixes onto current main in the consolidated PR, while leaving out stale removed-backend changes and broad churn that no longer applies.