Terminal Font Function

[dylanaraps]

This PR introduces two new functions,

term - Get the current terminal emulator.
termfont - Get the terminal font.

This closes #251.

TODO

• Add termfont support for popular terminal emulators.

Regular Configs:

• URxvt and Xterm
• Termite
• Xfce4-terminal
• Terminal.app
• Mintty

Profile Based Configs:

We need to figure out how to get the font on a per profile basis.

• Gnome-terminal
• Terminator
• Konsole
• iTerm2

No Configs:

Font support can't be added as these terminals are configured at compile time.

• st

Issues

• term doesn't work when run from inside a tmux session.
  • This is because the $PPID of tmux is systemd for some odd reason.
• term doesn't work on Windows.
  • This is because CYGWIN's ps command is missing the -o flag.
  • This has been fixed with an ugly solution imo.

Testing this PR

To test this PR just checkout this branch and run neofetch with
neofetch --config off.

[Brottweiler]

Termite is in your list twice.

[dylanaraps]

Thanks, the 2nd termite was supposed to be iTerm2. :)

[iandrewt]

Testing iTerm2 and Terminal.app now

[dylanaraps]

Font output won't work on them just yet but terminal detection should.

[iandrewt]

Alright. What do you think will be needed for tmux support? I just set it up today :/

[dylanaraps]

The terminal detection works by finding the parent process id of the current shell.
The parent process of tmux sessions on my pc (Not sure about others) is set to
systemd instead of the shell or terminal emulator for some reason.

This might work on OS X and other systems however and I just pushed a commit
for you to test out.

[iandrewt]

On iTerm2, it doesn't work at all, nothing is printed for Terminal Emulator

On Terminal.app, Terminal Emulator is login

[dylanaraps]

Is this inside or outside of tmux?

[iandrewt]

Outside

[dylanaraps]

We can workaround the OS X detection, iTerm2 has an envar and I'm sure
there's something similar for terminal.app

[dylanaraps]

@iandrewt, what's the value of $TERM_PROGRAM on your OS X system?
(Do echo $TERM_PROGRAM from both terminal emulators).

[iandrewt]

iTerm2 is iTerm.app, Terminal.app is Apple_Terminal. Added bonus, works in tmux.

[dylanaraps]

Sweet!

Once I'm at uni I'll add support for it.

[dylanaraps]

@iandrewt, can you test out the PR?

OS X terminal detection should work now.

[iandrewt]

Working for me in iTerm2 (Terminal Emulator: iTerm2), Terminal.app (Terminal Emulator: Apple_Terminal), and Termite (obviously, Terminal Emulator: termite)

[dylanaraps]

Awesome!

Now we just need to add config file parsing for the OS X terminals.

[tudurom]

Not every urxvt user has his colors in ~/.Xresources. For example, mine is in .xres/urxvt. You should parse the output of xrdb -query instead of .Xresources.

[dylanaraps]

That's a good idea, thanks.

[dylanaraps]

I want to get this merged soon, can anyone lurking here please test the PR
and let me know if you come across any issues?

Here's how you can test:

1. git clone https://github.com/dylanaraps/neofetch
2. cd neofetch
3. git checkout term_font
4. ./neofetch --config off

Thanks :)

[dawidd6]

Don't worrry about the logo ;)

[dylanaraps]

Weird that there's a - symbol on the end.

hm

[dylanaraps]

@dawidd6, the issue should be fixed now.

Please try it again when you have some time. :)

[dawidd6]

Now it's just right 👍