-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fts
(full text search) for Deno-sqlite
#108
Comments
I'd like to see |
Hm. I would be curious to test how much each feature effects the WASM binary size vs how much they are used to better understand the tradeoffs involved. It might also be interesting to offer some more documentation on how to compile your own version if you have specific needs. |
This is anecdotal, but I ran
And
|
The plan is to update this feature in the future once dyedgreen/deno-sqlite#108 is resolved to enable a real full-text search.
A thought on loading sqlite extensions: with |
Having |
@ashersaupingomez
You'd need to compile the WASM module yourself with the necessary build options enabled. https://www.sqlite.org/fts5.html should include all necessary information. |
Any update on this? I'm having no problem with a custom build with fts5 enabled but would prefer not to have the repo sitting in my project |
I've had some thoughts around using denos dll loader / a wash loader set-up to support loading custom extensions, but I don't have any specific progress on that yet. |
+1 for this feature. It is something I really need. |
I think this would be welcome at this point. It seems some people were able to enable fts without too much trouble. Perhaps @artisonian would be willing to publish his changes? I took a look at doing this myself but I'm quickly out of my depth. A maintained fork or branch with commonly requested configurations could be one way to address this. Thanks! |
@mdkq Can you share the commands you're using to build SQLite and use it with this library? |
@alexgleason You can fork this repo, make the changes to the config, and let Github actions build it for you. See the commits I made on my fork: https://github.com/teleclimber/deno-sqlite Then you can import it directly from Github:
Feel free to us mine to experiment with, but I make zero promises to keep it up to date right now (and it's already behind). |
@teleclimber Fantastic, thank you!!! |
Well, FTS works awesome with @teleclimber's fork. I'm even using it with Kysely query builder and it's wonderful. @dyedgreen Would you be open to merging 05ce37d? I can make a pull request. |
I think this is probably fine; I’d like to check if this extension is also enabled in nodes better sqlite but |
* Enable full-text search (FTS5) Fixes #108 * Alphabetize compile flags, add a comment about SQLITE_ENABLE_FTS5
(Originally posted by @hobochild in #100 (comment) )
Full text search seems like a common problem and it might make sense to enable full text search by default (since there is currently no way to import extensions at run-time). But I wanted to see how many others are interested in this functionality. (It it turns out to be too niche, it might make sense to ask people to compile their own WASM module with the extension enabled.)
For reference: SQLite full text search docs
The text was updated successfully, but these errors were encountered: