[OTE-821] Affiliates roundtable metrics #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dtable-affiliate-info
WalkthroughThis pull request introduces functionality to track the lag time since the last update in the persistent cache for both the Changes
Possibly related PRs
Suggested reviewers
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Files skipped from review as they are similar to previous changes (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Comment on lines
42
to
45
| stats.gauge( | ||
| `${config.SERVICE_NAME}.persistent_cache_${PersistentCacheKeys.AFFILIATE_INFO_UPDATE_TIME}_lag_seconds`, | ||
| DateTime.utc().diff(windowStartTime).as('seconds'), | ||
| ); |
There was a problem hiding this comment.
nit: actually since we can track this in the same dashboard let's do this
Suggested change
| stats.gauge( | |
| `${config.SERVICE_NAME}.persistent_cache_${PersistentCacheKeys.AFFILIATE_INFO_UPDATE_TIME}_lag_seconds`, | |
| DateTime.utc().diff(windowStartTime).as('seconds'), | |
| ); | |
| stats.gauge( | |
| `${config.SERVICE_NAME}.persistent_cache_lag_seconds`, | |
| DateTime.utc().diff(windowStartTime).as('seconds'), | |
| { cache: PersistentCacheKeys.AFFILIATE_INFO_UPDATE_TIME.}, | |
| ); |
There was a problem hiding this comment.
and also for the other task
jerryfan01234
force-pushed
the
affiliates-roundtable-metrics
branch
from
83228b7
to
cade120
Compare
Christopher-Li
approved these changes
Sep 20, 2024
This was referenced Sep 23, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
add metrics to update total volume and affiliate info roundtables
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
Tests