fix lint for affiliates

[affanv14]

Changelist

Fixes lint breaking change

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in affiliate tier update tests, ensuring that any issues are caught and reported for better reliability.

[coderabbitai]

Walkthrough

The changes involve enhancing error handling in the test cases for the UpdateAffiliateTiers function within the revshare_test.go file. The tests TestKeeper_GetAllRevShares_Valid and TestKeeper_GetAllRevShares_Invalid now check for errors returned by the function, ensuring that any failures are properly captured and reported. This systematic improvement strengthens the reliability of the tests without altering their overall logic.

Changes

File	Change Summary
protocol/x/revshare/keeper/revshare_test.go	Added error handling for UpdateAffiliateTiers in test cases to ensure errors are captured and asserted.

Possibly related PRs

• [OTE-692] Implement message server for affiliates #2216: Modifies the UpdateAffiliateTiers method to include error handling, directly related to the changes in the main PR.
• [OTE-779] Check affiliate tiers are strictly increasing before updating tiers #2220: Enhances the UpdateAffiliateTiers function with error handling and validation checks, aligning with the main PR's focus.
• [OTE-776] Implement GetAllRevshares #2228: Adds tests for the GetAllRevShares functionality, which may involve similar error handling practices.

🐇 In the meadow where bunnies play,
Error handling brightens the day!
With tests now robust, we leap with glee,
Ensuring our code runs error-free.
Hops of joy, let’s cheer and sing,
For every fix, new hope we bring! 🌼

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c3d96d and c6c26f6.

Files selected for processing (1)

• protocol/x/revshare/keeper/revshare_test.go (8 hunks)

Additional comments not posted (8)

protocol/x/revshare/keeper/revshare_test.go (8)

338-339: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

405-406: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

464-465: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

506-507: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

549-553: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

630-634: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

652-656: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

676-679: LGTM!

The addition of error handling for the UpdateAffiliateTiers function calls improves the robustness of the tests by ensuring that any issues with updating affiliate tiers are caught and reported.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.