Update main-net node setup. #2046
Conversation
WalkthroughThe changes made to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
protocol/testing/mainnet/mainnet.sh (1)
49-49: Inconsistency Detected: Align the usage ofLAST_FULL_NODE_INDEXacross all scriptsThe change to include the full node at index 0 in the directory creation process in
mainnet.shaligns with the usage instart.sh. However, there is an inconsistency withsnapshot.shwhere the loop starts from 1.
protocol/testing/mainnet/snapshot.sh(line 1):for i in $(seq 1 $LAST_FULL_NODE_INDEX); doprotocol/testing/mainnet/start.sh(line 1):for i in $(seq 0 $LAST_FULL_NODE_INDEX); doprotocol/testing/mainnet/mainnet.sh(lines 49, 54, 59):for i in $(seq 0 $LAST_FULL_NODE_INDEX); doEnsure that the loop index is consistent across all scripts to avoid any unintended side effects.
Analysis chain
LGTM! But verify the impact on node creation logic.
The change to include the full node at index 0 in the directory creation process is approved.
However, ensure that this change aligns with the overall node creation logic and does not introduce any unintended side effects.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of including the full node at index 0 in the directory creation process. # Test: Search for the usage of the variable `LAST_FULL_NODE_INDEX` in the codebase to ensure consistency. rg --type shell -A 5 $'LAST_FULL_NODE_INDEX'Length of output: 73
Script:
#!/bin/bash # Description: Verify the impact of including the full node at index 0 in the directory creation process. # Test: Search for the usage of the variable `LAST_FULL_NODE_INDEX` in the codebase to ensure consistency. rg -A 5 'LAST_FULL_NODE_INDEX'Length of output: 2610
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- protocol/testing/mainnet/mainnet.sh (1 hunks)
- protocol/testing/mainnet/start.sh (1 hunks)
Additional comments not posted (3)
protocol/testing/mainnet/start.sh (1)
12-12: LGTM! But verify the impact on node setup logic.The change to include the full node at index 0 in the setup process is approved.
However, ensure that this change aligns with the overall node setup logic and does not introduce any unintended side effects.
protocol/testing/mainnet/mainnet.sh (2)
64-64: LGTM! But verify the impact on node setup logic.The change to include the full node at index 0 in the CosmosVisor setup process is approved.
However, ensure that this change aligns with the overall node setup logic and does not introduce any unintended side effects.
56-56: LGTM! But verify the impact on node initialization logic.The change to include the full node at index 0 in the genesis file copying process is approved.
However, ensure that this change aligns with the overall node initialization logic and does not introduce any unintended side effects.
|
@Mergifyio backport release/protocol/v5.2.x |
✅ Backports have been created
|
(cherry picked from commit 2afb412)
Co-authored-by: vincentwschau <[email protected]>
|
@Mergifyio backport release/protocol/v6.x |
✅ Backports have been created
|
(cherry picked from commit 2afb412)
Co-authored-by: vincentwschau <[email protected]>
Changelist
Fix typo for the generation of full-node indices for the startup / setup scripts. Indices should start from 0 not 1.
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
Bug Fixes