Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update spanish localization #1722

Merged
merged 2 commits into from
Apr 22, 2024
Merged

update spanish localization #1722

merged 2 commits into from
Apr 22, 2024

Conversation

Victor-M-Giraldo
Copy link
Contributor

No description provided.

@Victor-M-Giraldo Victor-M-Giraldo requested a review from dyc3 as a code owner April 22, 2024 00:51
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 62.3458%. Comparing base (010f2da) to head (e0bdceb).

Files Patch % Lines
client/src/locales/es.ts 0.0000% 21 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             master      #1722        +/-   ##
================================================
- Coverage   62.3988%   62.3458%   -0.0530%     
================================================
  Files           168        168                
  Lines         24712      24733        +21     
  Branches       1445       1445                
================================================
  Hits          15420      15420                
- Misses         9238       9259        +21     
  Partials         54         54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dyc3
dyc3 requested changes Apr 22, 2024
View reviewed changes
Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a rubber stamp.

client/src/locales/es.ts Outdated Show resolved Hide resolved
client/src/locales/es.ts Outdated Show resolved Hide resolved
@dyc3 dyc3 merged commit 7b7c77c into dyc3:master Apr 22, 2024
20 of 21 checks passed
@cypress Cypress
Copy link

cypress bot commented Apr 22, 2024

Passing run #1811 ↗︎

0 82 1 0 Flakiness 0

Details:

update spanish localization (#1722)
Project: OpenTogetherTube Commit: 7b7c77c7d5
Status: Passed Duration: 05:04 💡
Started: Apr 22, 2024 1:42 AM Ended: Apr 22, 2024 1:47 AM

Review all test suite changes for PR #1722 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Victor-M-Giraldo @dyc3