client: refactor media controls to use composables instead of hacky component refs

[dyc3]

No description provided.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[cypress]

Passing run #1455 ↗︎

0

79

1

0

0

Details:

Merge c126f90 into 3d4f0ed...
Project: OpenTogetherTube	Commit: dcdf4b9c49 ℹ️
Status: Passed	Duration: 04:48 💡
Started: Mar 28, 2024 1:38 PM	Ended: Mar 28, 2024 1:43 PM

Review all test suite changes for PR #1572 ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 45.84615% with 176 lines in your changes are missing coverage. Please review.

Project coverage is 56.4409%. Comparing base (3d4f0ed) to head (c126f90).

Files	Patch %	Lines
client/src/components/players/OmniPlayer.vue	12.3456%	71 Missing ⚠️
client/src/components/composables/media-player.ts	65.4676%	48 Missing ⚠️
client/src/views/Room.vue	2.4390%	40 Missing ⚠️
client/src/components/players/PlyrPlayer.vue	0.0000%	11 Missing ⚠️
...t/src/components/controls/PlaybackRateSwitcher.vue	84.2105%	3 Missing ⚠️
client/src/components/controls/VideoControls.vue	71.4285%	2 Missing ⚠️
client/src/components/players/YoutubePlayer.vue	87.5000%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1572        +/-   ##
================================================
+ Coverage   56.3167%   56.4409%   +0.1242%     
================================================
  Files           164        163         -1     
  Lines         25005      24973        -32     
  Branches       1441       1443         +2     
================================================
+ Hits          14082      14095        +13     
+ Misses        10869      10824        -45     
  Partials         54         54                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dyc3]

After manually testing some more and passing the new e2e tests, I'm feeling pretty confident about this code.