-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using zod for validation for account recovery endpoints. #1555
Switch to using zod for validation for account recovery endpoints. #1555
Conversation
Victor-M-Giraldo
commented
Mar 22, 2024
- Related Integrate zod for HTTP request validation #1385
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Still need to fix the tests when I get home later. |
Something like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, better.
Something like this? I can't find out why the last test is failing when it should be succeeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, something like this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
================================================
+ Coverage 56.2520% 56.2985% +0.0465%
================================================
Files 164 164
Lines 24872 24990 +118
Branches 1435 1440 +5
================================================
+ Hits 13991 14069 +78
- Misses 10827 10867 +40
Partials 54 54 ☔ View full report in Codecov by Sentry. |
Passing run #1434 ↗︎
Details:
Review all test suite changes for PR #1555 ↗︎ |