Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow discovery polling interval to be configurable #1459

Merged

Conversation

moreno-michael
Copy link
Contributor

@moreno-michael moreno-michael commented Mar 7, 2024

closes #1295

@moreno-michael moreno-michael requested a review from dyc3 as a code owner March 7, 2024 04:59
Copy link
Contributor

coderabbitai bot commented Mar 7, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@moreno-michael moreno-michael marked this pull request as draft March 7, 2024 04:59
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.2520%. Comparing base (1b9206f) to head (41680b7).

❗ Current head 41680b7 differs from pull request most recent head 91a2274. Consider uploading reports for the commit 91a2274 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1459   +/-   ##
===========================================
  Coverage   56.2520%   56.2520%           
===========================================
  Files           164        164           
  Lines         24872      24872           
  Branches       1435       1435           
===========================================
  Hits          13991      13991           
  Misses        10827      10827           
  Partials         54         54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`polling_duration` configurability
Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far

crates/ott-common/src/discovery/dns.rs Outdated Show resolved Hide resolved
crates/ott-common/src/discovery/dns.rs Outdated Show resolved Hide resolved
@moreno-michael moreno-michael force-pushed the make-polling-discovery-interval-configurable branch from 331074d to 6306558 Compare March 7, 2024 17:39
@moreno-michael moreno-michael marked this pull request as ready for review March 21, 2024 20:50
Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

crates/ott-common/src/discovery/dns.rs Outdated Show resolved Hide resolved
crates/ott-common/src/discovery/fly.rs Outdated Show resolved Hide resolved
@dyc3 dyc3 merged commit 2961b94 into dyc3:master Mar 21, 2024
21 checks passed
Copy link

cypress bot commented Mar 21, 2024

Passing run #1400 ↗︎

0 75 1 0 Flakiness 0

Details:

allow discovery polling interval to be configurable (#1459)
Project: OpenTogetherTube Commit: 2961b9483e
Status: Passed Duration: 05:07 💡
Started: Mar 21, 2024 9:28 PM Ended: Mar 21, 2024 9:33 PM

Review all test suite changes for PR #1459 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make monolith discovery polling interval configurable
2 participants