use purgecss to remove tons of unused css from bundles #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1455 +/- ##
================================================
- Coverage 62.8452% 62.6590% -0.1862%
================================================
Files 168 169 +1
Lines 24912 24986 +74
Branches 1444 1445 +1
================================================
Hits 15656 15656
- Misses 9203 9276 +73
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. |
Passing run #1972 ↗︎
Details:
Review all test suite changes for PR #1455 ↗︎ |
|||||||||||||||
dyc3
force-pushed
the
purgecss
branch
3 times, most recently
from
880ee1b to
3e99ded
Compare
|
There's still some missing styles that need to be resolved before this can be merged
|
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-05-01 01:48:18.868265438 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-05-01 01:48:19.028265726 +0000
@@ -1,6 +1,6 @@
-�[36mvite v5.2.8 �[32mbuilding for production...�[36m�[39m
+�[36mvite v5.2.10 �[32mbuilding for production...�[36m�[39m
transforming...
-�[32m✓�[39m 811 modules transformed.
+�[32m✓�[39m 832 modules transformed.
rendering chunks...
computing gzip size...
�[2mdist/�[22m�[32mindex.html �[39m�[1m�[2m 0.90 kB�[22m�[1m�[22m�[2m │ gzip: 0.52 kB�[22m
@@ -22,27 +22,27 @@
�[2mdist/�[22m�[2massets/�[22m�[35mGoogleDrivePlayer-hash.css �[39m�[1m�[2m 0.11 kB�[22m�[1m�[22m�[2m │ gzip: 0.12 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mYoutubePlayer-hash.css �[39m�[1m�[2m 0.15 kB�[22m�[1m�[22m�[2m │ gzip: 0.14 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[35mRoomList-hash.css �[39m�[1m�[2m 0.31 kB�[22m�[1m�[22m�[2m │ gzip: 0.22 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css �[39m�[1m�[2m 0.93 kB�[22m�[1m�[22m�[2m │ gzip: 0.39 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 12.25 kB�[22m�[1m�[22m�[2m │ gzip: 2.93 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css �[39m�[1m�[2m 30.56 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 367.61 kB�[22m�[1m�[22m�[2m │ gzip: 58.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mPlyrPlayer-hash.css �[39m�[1m�[2m 0.47 kB�[22m�[1m�[22m�[2m │ gzip: 0.28 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mHome-hash.css �[39m�[1m�[2m 0.82 kB�[22m�[1m�[22m�[2m │ gzip: 0.35 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mRoom-hash.css �[39m�[1m�[2m 11.75 kB�[22m�[1m�[22m�[2m │ gzip: 2.85 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[35mindex-hash.css �[39m�[1m�[2m 206.92 kB�[22m�[1m�[22m�[2m │ gzip: 29.31 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mpirate-hash.js �[39m�[1m�[2m 0.32 kB�[22m�[1m�[22m�[2m │ gzip: 0.25 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js �[39m�[1m�[2m 1.04 kB�[22m�[1m�[22m�[2m │ gzip: 0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.95 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js �[39m�[1m�[2m 2.31 kB�[22m�[1m�[22m�[2m │ gzip: 1.08 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js �[39m�[1m�[2m 2.64 kB�[22m�[1m�[22m�[2m │ gzip: 1.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.05 kB�[22m�[1m�[22m�[2m │ gzip: 51.41 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 24.97s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.95 kB�[22m�[1m�[22m�[2m │ gzip: 12.51 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 163.89 kB�[22m�[1m�[22m�[2m │ gzip: 51.35 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.68 kB�[39m�[22m�[2m │ gzip: 173.48 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 766.73 kB�[39m�[22m�[2m │ gzip: 255.03 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.51 kB�[39m�[22m�[2m │ gzip: 379.29 kB�[22m
+�[32m✓ built in 27.55s�[39m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not entirely sure I want to merge this considering how much hacky stuff I had to do
I think it would be a good idea to land some snapshot tests first to make sure there aren't any differences