-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix k6 load tests so post bodies will be json #1384
Conversation
By default, k6/http will encode post requests as `x-www-form-urlencoded`. This can result in boolean values getting interpreted by the monolith as strings. Related: #1339
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai Create an issue to start using zod to parse and validate HTTP requests |
@dyc3: The issue to start using zod for parsing and validating HTTP requests has been successfully created. You can view and track the progress here. Analysis chainScripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Create a GitHub issue for integrating zod for HTTP request validation.
gh issue create --title "Integrate zod for HTTP request validation" --body "This issue tracks the task of integrating zod to parse and validate HTTP requests in the project, as discussed in https://github.com/dyc3/opentogethertube/pull/1384. Using zod will help in ensuring that the HTTP requests conform to the expected schema, enhancing the robustness and security of request handling."
Length of output: 443 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1384 +/- ##
===========================================
Coverage 54.1663% 54.1663%
===========================================
Files 158 158
Lines 24650 24650
Branches 1437 1437
===========================================
Hits 13352 13352
Misses 11241 11241
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Passing run #1096 ↗︎
Details:
Review all test suite changes for PR #1384 ↗︎ |
By default, k6/http will encode post requests as
x-www-form-urlencoded
. This can result in boolean values getting interpreted by the monolith as strings.Related: #1339