balancer: add a command line argument to validate config

[Victor-M-Giraldo]

closes #1296

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c483d9) 62.6449% compared to head (e231011) 54.1641%.
Report is 32 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1317        +/-   ##
================================================
- Coverage   62.6449%   54.1641%   -8.4809%     
================================================
  Files           118        158        +40     
  Lines          8711      24651     +15940     
  Branches       1168       1437       +269     
================================================
+ Hits           5457      13352      +7895     
- Misses         3254      11242      +7988     
- Partials          0         57        +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Victor-M-Giraldo]

This isn't working yet. I think its because load returns an Ok(()) so it always exits with code 0.

[Victor-M-Giraldo]

Yeah, I think I'm going to need some help with this, or at least some direction.

The two ideas I had were making a function similar to postProcessConfig in ott-config.ts where if the discovery method was with fly for example it checked that the monolith_port and fly_app were defined. Don't think that's the right way to go though.

The other was messing around with load.

[dyc3]

Have you looked at the docs for the figment crate yet?

[Victor-M-Giraldo]

Yes, but I was having some trouble understanding them. I'll take another look though and let you know.

[Victor-M-Giraldo]

Going to add messages indicating whether config validation succeeded or failed when I get home.

[cypress]

Passing run #1055 ↗︎

0

73

1

0

0

Details:

balancer: add a command line argument to validate config (#1317)
Project: OpenTogetherTube	Commit: 000cd64e73
Status: Passed	Duration: 03:41 💡
Started: Feb 20, 2024 9:40 PM	Ended: Feb 20, 2024 9:44 PM

Review all test suite changes for PR #1317 ↗︎