Add compatibility with Docker dns servers #1290
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the WalkthroughThis update introduces a new module Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
=================================================
- Coverage 61.5596% 47.1016% -14.4580%
=================================================
Files 118 151 +33
Lines 9438 18114 +8676
Branches 1161 1233 +72
=================================================
+ Hits 5810 8532 +2722
- Misses 3628 9582 +5954 ☔ View full report in Codecov by Sentry. |
moreno-michael
changed the title
moreno-michael
changed the title
There was a problem hiding this comment.
Took a closer look, and this module isn't being included. add mod dns to discovery.rs, update DiscoveryConfig and fix the compiler errors.
You should be able to run the balancer with the following configuration:
[discovery]
method = "dns"
query = "foo"I think The demo we did during today's meeting worked because I had the balancer configured with the manual discoverer. That or I forgot to rebuild the container
compiler issues
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- crates/ott-balancer/src/discovery.rs (1 hunks)
- crates/ott-balancer/src/discovery/dns.rs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- crates/ott-balancer/src/discovery/dns.rs
Additional comments: 2
crates/ott-balancer/src/discovery.rs (2)
- 10-10: The addition of the
dnsmodule is noted. Ensure that the implementation within this module aligns with the objectives of enhancing compatibility with Docker DNS servers and follows best practices for DNS queries, especially considering the IPv4 address requirement.- 7-13: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-120]
Overall, the file maintains a clear structure and separation of concerns among different discovery methods. Ensure that the
dnsmodule is properly integrated and utilized within theDiscoveryTaskandstart_discovery_taskfunctions, following the async and trait-based patterns established in the file. This integration is crucial for the DNS-based discovery to function as intended within the system's architecture.
…opentogethertube into dns-server-compatibility
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 failed test on run #996 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Screenshots
Video
|
|
Review all test suite changes for PR #1290 ↗︎
* added dns.rs, adds compatibility with dns servers * Adjusted format for Docker DNS * added missing field * made suggested changes, working on resolving compiler issues * fixed compiler issues * ran cargo fmt * made most suggested changes * fixing compiler issues * update balancer config for docker * Update crates/ott-balancer/src/discovery/dns.rs --------- Co-authored-by: Carson McManus <[email protected]> Co-authored-by: Carson McManus <[email protected]>
resolves #1239