Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add reconnect query param to websocket reconnects #1278

Merged
merged 1 commit into from
Jan 29, 2024
Merged

client: add reconnect query param to websocket reconnects #1278

merged 1 commit into from
Jan 29, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jan 28, 2024

No description provided.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2024

Warning

Rate Limit Exceeded

@dyc3 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 18 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between d1d906f and 34cc351.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@dyc3 dyc3 modified the milestone: Load Balancing Jan 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (abd5d09) 60.8976% compared to head (34cc351) 61.6195%.
Report is 5 commits behind head on master.

Files Patch % Lines
client/src/plugins/connection.ts 33.3333% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             master      #1278        +/-   ##
================================================
+ Coverage   60.8976%   61.6195%   +0.7219%     
================================================
  Files           118        118                
  Lines          9915       9484       -431     
  Branches       1158       1158                
================================================
- Hits           6038       5844       -194     
+ Misses         3877       3640       -237

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Jan 28, 2024

Passing run #891 ↗︎

0 71 1 0 Flakiness 0

Details:

Merge 34cc351 into d1d906f...
Project: OpenTogetherTube Commit: 0febf17313 ℹ️
Status: Passed Duration: 03:08 💡
Started: Jan 28, 2024 11:33 PM Ended: Jan 28, 2024 11:36 PM

Review all test suite changes for PR #1278 ↗︎

@dyc3 dyc3 merged commit 6bc0be1 into master Jan 29, 2024
19 of 20 checks passed
@dyc3 dyc3 deleted the client-reconnect branch January 29, 2024 00:08
Victor-M-Giraldo pushed a commit to Victor-M-Giraldo/opentogethertube that referenced this pull request Feb 6, 2024
@dyc3
client: add reconnect query param to websocket reconnects (dyc3#1278)
f0882df
dyc3 added a commit that referenced this pull request Feb 6, 2024
@Victor-M-Giraldo @dyc3 @moreno-michael
make monolith ids constant (#1287)
8ec4945 
* added monolith id in M2BInit

* ran typeshare script

* generate UUID in init message

* made m_id global and ran yarn lint

* removed stray import

* updated balancer to use id in init message

* changed id variable name

* attempt at test

* updates to unit test

* more changes

* finalized test

* removed message struct

* filter for argument being type init

* dev: actually ignore ts-out, ignore other built files (#1277)

* client: add `reconnect` query param to websocket reconnects (#1278)

* clean up unused config files (#1279)

* ott-vis: add strict to tsconfig (#1282)

* client: remove mentions of reddit source support from add preview UI (#1269)

* issue 1228

removed mentions of subreddit source support from UI and localizations

* ran yarn lint

* fix room url connection parsing (#1284)

* server: improve parsing of websocket connection URL, and add tests (#1288)

* add unit tests for parsing websocket connection url

* add e2e test for websocket reconnects

* account for base_url and make parsing more robust

* revert to previous implementation

* fixed test

* ensure ids are not undefined

---------

Co-authored-by: Carson McManus <[email protected]>
Co-authored-by: moreno-michael <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dyc3