dash: clean up objects when video changes

[dyc3]

No description provided.

[coderabbitai]

Walkthrough

The changes involve setting the hls and dash instances to undefined after their destruction/reset methods are called in the PlyrPlayer.vue component. This is likely done to ensure proper cleanup and garbage collection, avoiding potential memory leaks by clearing references to the instances.

Changes

File Path	Change Summary
.../players/PlyrPlayer.vue	Set hls and dash to undefined after calling destroy() and reset() respectively.

🐰✨
In the code where players play,
A tiny fix hops in today.
No more lingering, no more stray,
hls and dash fade away.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 51c598c and e3529b1.

Files selected for processing (1)

• client/src/components/players/PlyrPlayer.vue (3 hunks)

Additional comments: 1

client/src/components/players/PlyrPlayer.vue (1)

• 209-212: The changes to set hls and dash to undefined after their cleanup methods are called are correct and follow best practices for memory management in JavaScript.

[cypress]

1 failed test on run #836 ↗︎

1

60

1

0

0

Details:

Merge e3529b1 into 51c598c...
Project: OpenTogetherTube	Commit: 1127252229 ℹ️
Status: Failed	Duration: 03:23 💡
Started: Jan 18, 2024 2:08 PM	Ended: Jan 18, 2024 2:12 PM

  client/tests/e2e/component/Chat.cy.ts • 1 failed test • Component - electron

View Output Video

Test		Artifacts
An uncaught error was detected outside of a test		Screenshots Video

Review all test suite changes for PR #1234 ↗︎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06b4a6c) 61.5597% compared to head (e3529b1) 61.5556%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1234        +/-   ##
================================================
- Coverage   61.5597%   61.5556%   -0.0041%     
================================================
  Files           117        117                
  Lines          9412       9411         -1     
  Branches       1156       1155         -1     
================================================
- Hits           5794       5793         -1     
  Misses         3618       3618                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.