server: fix parsing iso8601 durations with decimals in the seconds place

[dyc3]

No description provided.

[coderabbitai]

Walkthrough

The update enhances the parseIso8601Duration function to interpret ISO 8601 durations that include fractional seconds. The regular expression used for parsing has been refined to recognize decimal seconds, and the function now processes these values correctly as floating-point numbers.

Changes

File Path	Change Summary
.../parsing/iso8601.ts, .../parsing/iso8601.spec.ts	Updated to support parsing of fractional seconds in ISO 8601 duration strings.

Poem

A tick, a tock, a tiny dot,
Fractions pass; we've caught the lot.
🐇 Seconds split, so finely spun,
Our code now greets each decimal one.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 06b4a6c and 7e2c34c.

Files selected for processing (2)

• server/services/parsing/iso8601.ts (2 hunks)
• server/tests/unit/services/parsing/iso8601.spec.ts (1 hunks)

Additional comments: 4

server/tests/unit/services/parsing/iso8601.spec.ts (1)

• 6-7: The new test cases for parseIso8601Duration function correctly check for the parsing of ISO8601 durations with fractional seconds. This is a good addition to ensure that the updated parsing logic is being tested for the new functionality.

server/services/parsing/iso8601.ts (3)

• 6-6: The updated regex pattern now correctly includes the possibility of decimal fractions in the seconds component, which aligns with the objective of parsing ISO 8601 duration strings with fractional seconds.
• 11-11: The replacement logic within the map function is now correctly stripping non-numeric characters, which would include the period for decimal fractions. This is necessary for the subsequent parsing of the string into a floating-point number.
• 22-22: The seconds are now being parsed as a floating-point number instead of an integer, which is crucial for handling fractional seconds. This change is correct and necessary for the feature implementation.

[cypress]

2 failed tests on run #830 ↗︎

2

56

1

0

0

Details:

Merge 7e2c34c into 06b4a6c...
Project: OpenTogetherTube	Commit: d9f5e79fed ℹ️
Status: Failed	Duration: 03:33 💡
Started: Jan 17, 2024 3:38 PM	Ended: Jan 17, 2024 3:42 PM

  Chat.cy.ts • 1 failed test • Component - electron

View Output Video

Test		Artifacts
An uncaught error was detected outside of a test		Screenshots Video

  ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test		Artifacts
An uncaught error was detected outside of a test		Screenshots Video

Review all test suite changes for PR #1230 ↗︎