harness: consume output of balancer when running tests #1221

Victor-M-Giraldo · 2024-01-13T21:51:23Z

…r-M-Giraldo/opentogethertube into consume-output-of-balancer

coderabbitai · 2024-01-13T21:51:28Z

Walkthrough

The recent update to the TestRunner within the harness software aims to manage the log output from the balancer during test execution. By capturing the standard output and error streams, the system can conditionally display these logs based on the --nocapture flag's presence, thereby reducing clutter in the test output.

Changes

File Pattern	Change Summary
`crates/harness/src/test_runner.rs`	Updated to capture stdout and stderr from the balancer process and introduced asynchronous functions to handle and log the output.

Assessment against linked issues

Objective	Addressed	Explanation
#1188: Consume and re-emit balancer logs in the harness during tests	✅

Poem

To the logs that flow like a verbose stream,
🐇 CodeRabbit hushed their endless dream.
With a capture, a toggle, a quiet reprieve,
Now only when asked, shall the console receive.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Victor-M-Giraldo · 2024-01-13T21:52:47Z

Do you mean something like this? I'm aware it doesn't log it back out to the parent process quite yet.

Also, I know it makes some of the tests to fail for now.

codecov · 2024-01-13T21:55:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3937c8) 61.4906% compared to head (3a2dc72) 61.7090%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1221        +/-   ##
================================================
+ Coverage   61.4906%   61.7090%   +0.2184%     
================================================
  Files           115        115                
  Lines          9338       9467       +129     
  Branches       1145       1152         +7     
================================================
+ Hits           5742       5842       +100     
- Misses         3596       3625        +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between b0c3bca and 6f3064b.

Files selected for processing (1)

crates/harness/src/test_runner.rs (1 hunks)

coderabbitai · 2024-01-13T21:55:17Z

crates/harness/src/test_runner.rs

+
+        let _stdout = child.stdout.take().expect("Failed to capture stdout.");
+        let _stderror = child.stderr.take().expect("Failed to capture stderror.");


The stdout and stderr of the child process are being captured but not used. This could lead to confusion or bugs if the intention was to handle these streams later. It's important to either implement the handling of these streams or remove the capture if it's unnecessary.

The captured stdout and stderr are not being re-emitted. This needs to be addressed to meet the PR objectives. The code should be modified to conditionally re-emit these logs based on the --nocapture flag.

The test test_balancer_restart does not seem to verify the new behavior related to stdout and stderr capturing. Additional tests should be added to ensure that the capturing and conditional re-emission of logs are working as intended.

crates/harness/src/test_runner.rs

dyc3 · 2024-01-13T23:35:11Z

@Victor-M-Giraldo If it prevents stdout and stderr from being logged to the console, yeah. This isn't really enough for me to give meaningful feedback.

Victor-M-Giraldo · 2024-01-14T00:00:43Z

Do you think you might have some time tomorrow anywhere between 9-12 to join a call and help me out with this?

I know the task should be pretty easy, but i'm having some trouble with it.

dyc3 · 2024-01-14T01:13:56Z

Yeah I got time at like 10am

Victor-M-Giraldo · 2024-01-14T02:19:31Z

That works. Thank you.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6f3064b and 3a2dc72.

Files selected for processing (1)

crates/harness/src/test_runner.rs (3 hunks)

Files skipped from review as they are similar to previous changes (1)

crates/harness/src/test_runner.rs

Victor added 2 commits January 13, 2024 16:41

grab stdout & stderror

834a32d

Merge branch 'consume-output-of-balancer' of https://github.com/Victo…

6f3064b

…r-M-Giraldo/opentogethertube into consume-output-of-balancer

Victor-M-Giraldo marked this pull request as ready for review January 13, 2024 21:54

Victor-M-Giraldo requested a review from dyc3 as a code owner January 13, 2024 21:54

coderabbitai bot reviewed Jan 13, 2024

View reviewed changes

Victor-M-Giraldo marked this pull request as draft January 13, 2024 21:55

dyc3 changed the title ~~consume output of balancer~~ harness: consume output of balancer when running tests Jan 13, 2024

Victor and others added 2 commits January 14, 2024 10:23

minor change

fe7d53a

spawn tasks to relog the child process logs

3a2dc72

Victor-M-Giraldo marked this pull request as ready for review January 14, 2024 18:28

coderabbitai bot reviewed Jan 14, 2024

View reviewed changes

dyc3 approved these changes Jan 14, 2024

View reviewed changes

dyc3 merged commit 8338d83 into dyc3:master Jan 14, 2024
14 of 16 checks passed

Victor-M-Giraldo deleted the consume-output-of-balancer branch January 19, 2024 02:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

harness: consume output of balancer when running tests #1221

harness: consume output of balancer when running tests #1221

Victor-M-Giraldo commented Jan 13, 2024

coderabbitai bot commented Jan 13, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

Victor-M-Giraldo commented Jan 13, 2024 •

edited

Loading

codecov bot commented Jan 13, 2024 •

edited

Loading

coderabbitai bot left a comment

coderabbitai bot Jan 13, 2024

dyc3 commented Jan 13, 2024

Victor-M-Giraldo commented Jan 14, 2024

dyc3 commented Jan 14, 2024

Victor-M-Giraldo commented Jan 14, 2024

coderabbitai bot left a comment


		let _stdout = child.stdout.take().expect("Failed to capture stdout.");
		let _stderror = child.stderr.take().expect("Failed to capture stderror.");

harness: consume output of balancer when running tests #1221

harness: consume output of balancer when running tests #1221

Conversation

Victor-M-Giraldo commented Jan 13, 2024

coderabbitai bot commented Jan 13, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Victor-M-Giraldo commented Jan 13, 2024 • edited Loading

codecov bot commented Jan 13, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jan 13, 2024

Choose a reason for hiding this comment

dyc3 commented Jan 13, 2024

Victor-M-Giraldo commented Jan 14, 2024

dyc3 commented Jan 14, 2024

Victor-M-Giraldo commented Jan 14, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Jan 13, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

Victor-M-Giraldo commented Jan 13, 2024 •

edited

Loading

codecov bot commented Jan 13, 2024 •

edited

Loading