balancer: fix infinite loop in client connection handling #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
===========================================
Coverage 61.5318% 61.5318%
===========================================
Files 115 115
Lines 9322 9322
Branches 1141 1141
===========================================
Hits 5736 5736
Misses 3586 3586 ☔ View full report in Codecov by Sentry. |
2 failed tests on run #783 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Screenshots
Video
|
|
ShareInvite.cy.ts • 1 failed test • Component - electron
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Screenshots
Video
|
|
Review all test suite changes for PR #1202 ↗︎
Victor-M-Giraldo
approved these changes
Jan 6, 2024
| } | ||
| } | ||
|
|
||
| msg = stream.next() => { | ||
| if let Some(Ok(msg)) = msg { | ||
| Some(msg) = stream.next() => { |
There was a problem hiding this comment.
Is this using pattern matching?
There was a problem hiding this comment.
Yes, see the docs for tokio::select!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1187