Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer: improve connection manager resilience #1200

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jan 4, 2024

This makes is so the balancer gets notified if a monolith becomes unavailable, but the discovered monoliths haven't updated yet.

This makes is so the balancer gets notified if a monolith becomes unavailable, but the discovered monoliths haven't updated yet.
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6126213) 61.4426% compared to head (5ec8ab0) 61.4426%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1200   +/-   ##
===========================================
  Coverage   61.4426%   61.4426%           
===========================================
  Files           115        115           
  Lines          9316       9316           
  Branches       1139       1139           
===========================================
  Hits           5724       5724           
  Misses         3592       3592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 4, 2024

1 failed test on run #779 ↗︎

1 67 1 0 Flakiness 0

Details:

Merge 5ec8ab0 into 6126213...
Project: OpenTogetherTube Commit: 9658fe9613 ℹ️
Status: Failed Duration: 03:39 💡
Started: Jan 4, 2024 5:02 PM Ended: Jan 4, 2024 5:05 PM
Failed  client/tests/e2e/component/ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video

Review all test suite changes for PR #1200 ↗︎

@dyc3 dyc3 merged commit f554b29 into master Jan 6, 2024
16 of 18 checks passed
@dyc3 dyc3 deleted the monolith-connection-handling branch January 6, 2024 18:21
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
This makes is so the balancer gets notified if a monolith becomes unavailable, but the discovered monoliths haven't updated yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants