harness: improve robustness of tests #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyc3
force-pushed
the
harness-test-robustness
branch
from
866d0e2 to
a708f3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
===========================================
Coverage 61.4426% 61.4426%
===========================================
Files 115 115
Lines 9316 9316
Branches 1139 1139
===========================================
Hits 5724 5724
Misses 3592 3592 ☔ View full report in Codecov by Sentry. |
Passing run #768 ↗︎
Details:
Review all test suite changes for PR #1194 ↗︎ |
|||||||||||||||
cjrkoa
pushed a commit
to cjrkoa/opentogethertube
that referenced
this pull request
Jan 26, 2024
* improve robustness of `should_update_load_epoch_when_balancer_restart_2_monoliths` * slightly improve `should_prioritize_same_region_ws` robustness * refactor harness discoverer to make it easier to debug * fix harness discoverer sometimes listening on a port that is already being used * improve some error messages * use ipv6 localhost to check port availability * minor refactor * automatically try to restart the balancer if starting it the first time fails * make `route_ws_to_correct_monolith_race` much less flaky * improve reliability of `should_not_unload_rooms_when_balancer_restart` * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should_update_load_epoch_when_balancer_restart_2_monolithsshould_prioritize_same_region_wsrobustnessroute_ws_to_correct_monolith_racemuch less flakyshould_not_unload_rooms_when_balancer_restartDramatically improves the robustness of many of our tests. However, I think we might need to go back to the drawing board with how the emulated monolith works, specifically with regards to receiving messages in order to completely fix it.