Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve type checking for room api #1193

Merged
merged 2 commits into from
Jan 5, 2024
Merged

improve type checking for room api #1193

merged 2 commits into from
Jan 5, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 22, 2023

No description provided.

Copy link

cypress bot commented Dec 22, 2023

2 failed tests on run #766 ↗︎

2 56 1 0 Flakiness 0

Details:

Merge 488eb0a into 6a5498d...
Project: OpenTogetherTube Commit: ae1246bd60 ℹ️
Status: Failed Duration: 03:53 💡
Started: Dec 22, 2023 4:35 PM Ended: Dec 22, 2023 4:38 PM
Failed  Chat.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video
Failed  ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video

Review all test suite changes for PR #1193 ↗︎

@dyc3 dyc3 enabled auto-merge (squash) December 22, 2023 16:34
@dyc3 dyc3 disabled auto-merge December 22, 2023 16:36
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f65eaf6) 60.8222% compared to head (488eb0a) 61.4294%.
Report is 1 commits behind head on master.

Files Patch % Lines
server/api/room.ts 50.0000% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1193        +/-   ##
================================================
+ Coverage   60.8222%   61.4294%   +0.6072%     
================================================
  Files           115        115                
  Lines          9924       9318       -606     
  Branches       1139       1139                
================================================
- Hits           6036       5724       -312     
+ Misses         3888       3594       -294     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 merged commit 2cede3c into master Jan 5, 2024
15 of 16 checks passed
@dyc3 dyc3 deleted the types-room-api branch January 5, 2024 18:15
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
* improve type checking for room api

* fix lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant