Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ott-balancer-bin into 2 crates #1190

Merged
merged 2 commits into from
Dec 21, 2023
Merged

split ott-balancer-bin into 2 crates #1190

merged 2 commits into from
Dec 21, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 21, 2023

  • rename ott-balancer-bin to ott-balancer
  • add new ott-balancer-bin that just calls in to the ott-balancer crate

closes #1184

Copy link

cypress bot commented Dec 21, 2023

Passing run #763 ↗︎

0 71 1 0 Flakiness 0

Details:

Merge 055e8e2 into f65eaf6...
Project: OpenTogetherTube Commit: 51afa38d24 ℹ️
Status: Passed Duration: 03:40 💡
Started: Dec 21, 2023 9:14 PM Ended: Dec 21, 2023 9:18 PM

Review all test suite changes for PR #1190 ↗︎

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f65eaf6) 60.8222% compared to head (055e8e2) 61.7811%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1190        +/-   ##
================================================
+ Coverage   60.8222%   61.7811%   +0.9588%     
================================================
  Files           115        115                
  Lines          9924       9477       -447     
  Branches       1139       1151        +12     
================================================
- Hits           6036       5855       -181     
+ Misses         3888       3622       -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 merged commit 6a5498d into master Dec 21, 2023
18 checks passed
@dyc3 dyc3 deleted the crate-split branch December 21, 2023 21:21
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
* rename `ott-balancer-bin` to `ott-balancer`

* add new `ott-balancer-bin` that just calls in to the `ott-balancer` crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

balancer: split into 2 crates: ott-balancer and ott-balancer-bin
1 participant