Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial attempt to fix title > 255 char #1189

Merged
merged 13 commits into from
Jan 5, 2024
Merged

initial attempt to fix title > 255 char #1189

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0a407c3
initial attempt to fix title > 255 char
Dec 21, 2023
1040235
added title to OttApiRequestRoomCreate
Dec 22, 2023
07d5a71
add validator to createRoom & throw proper error
Dec 22, 2023
2a6888c
Merge branch 'dyc3:master' into fix/room-title-length
Victor-M-Giraldo Dec 22, 2023
403dc4c
ran yarn lint
Dec 22, 2023
01f63f8
Merge branch 'dyc3:master' into fix/room-title-length
Victor-M-Giraldo Dec 25, 2023
c6ac50d
add title test for create endpoint
Jan 2, 2024
b834666
fixed unit test for create endpoint, added unit test for patch endpoint
Jan 3, 2024
474b360
fixed stray import
Jan 3, 2024
0bbcc13
fixed post endpoint unit test
Jan 3, 2024
2495c02
one more fix
Jan 3, 2024
01bcbd6
added authorization to request
Jan 5, 2024
934465f
ran yarn lint
Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions server/tests/unit/api/room.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import _ from "lodash";
import _, { before } from "lodash";
import { QueueMode, Visibility } from "../../../../common/models/types";
Victor-M-Giraldo marked this conversation as resolved.
Show resolved Hide resolved
import request from "supertest";
import tokens from "../../../../server/auth/tokens";
Expand Down Expand Up @@ -228,7 +228,8 @@ describe("Room API", () => {
[
{ arg: "title", reason: "not allowed (too long, must be at most 255 characters)" },
{
name: "abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab",
name: "foo",
title: "abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab",
isTemporary: true,
},
],
Expand Down Expand Up @@ -316,4 +317,43 @@ describe("Room API", () => {
});
}
});

describe("POST /api/room/:name", () => {
let getSessionInfoSpy: jest.SpyInstance;
let validateSpy: jest.SpyInstance;
beforeAll(async () => {
getSessionInfoSpy = jest.spyOn(tokens, "getSessionInfo").mockResolvedValue({
isLoggedIn: false,
username: "test",
});
validateSpy = jest.spyOn(tokens, "validate").mockResolvedValue(true);
});

afterAll(() => {
getSessionInfoSpy.mockRestore();
validateSpy.mockRestore();
});

afterEach(async () => {
try {
await roommanager.unloadAllRooms();
} catch (e) {
if (!(e instanceof RoomNotFoundException)) {
throw e;
}
}
await UserModel.destroy({ where: {} });
});

it.each([
[
{ arg: "title", reason: "not allowed (too long, must be at most 255 characters)" },
{
name: "foo",
title: "abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab",
isTemporary: true,
},
],
]);
});
});
Loading