balancer: reduce lock contention when processing inbound client messages #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
================================================
+ Coverage 61.3205% 61.6883% +0.3677%
================================================
Files 115 115
Lines 9390 9394 +4
Branches 1135 1136 +1
================================================
+ Hits 5758 5795 +37
+ Misses 3632 3599 -33 ☔ View full report in Codecov by Sentry. |
Passing run #747 ↗︎
Details:
Review all test suite changes for PR #1178 ↗︎ |
|||||||||||||||
dyc3
force-pushed
the
balancer-rework
branch
from
9b115a2 to
a6276b4
Compare
cjrkoa
approved these changes
Dec 18, 2023
cjrkoa
pushed a commit
to cjrkoa/opentogethertube
that referenced
this pull request
Jan 26, 2024
…ges (dyc3#1178) * set up clients so that they can have a unicast channel and a broadcast channel * set up clients to have all the right channels * rename some vars * fix incorrect serialization * fix lints * fix lints * uncomment a line * rename some stuff to be clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #1151 to be merged first, need the tests it adds
cc @cjrkoa