Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer: add message latency benchmarks #1173

Merged
merged 2 commits into from
Dec 23, 2023
Merged

balancer: add message latency benchmarks #1173

merged 2 commits into from
Dec 23, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 13, 2023

benchmarks can be run with cargo bench

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bc8b99) 61.4426% compared to head (c210a79) 61.4426%.

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1173   +/-   ##
===========================================
  Coverage   61.4426%   61.4426%           
===========================================
  Files           115        115           
  Lines          9316       9316           
  Branches       1139       1139           
===========================================
  Hits           5724       5724           
  Misses         3592       3592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 13, 2023

2 failed tests on run #770 ↗︎

2 56 1 0 Flakiness 0

Details:

Merge 534f31d into 3bc8b99...
Project: OpenTogetherTube Commit: 3b4f90cc92 ℹ️
Status: Failed Duration: 03:35 💡
Started: Dec 23, 2023 3:47 PM Ended: Dec 23, 2023 3:50 PM
Failed  Chat.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video
Failed  ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video

Review all test suite changes for PR #1173 ↗︎

@dyc3 dyc3 changed the title balancer: add benchmarks balancer: add message latency benchmarks Dec 23, 2023
@dyc3 dyc3 added this to the Load Balancing milestone Dec 23, 2023
@dyc3 dyc3 marked this pull request as ready for review December 23, 2023 15:49
@dyc3 dyc3 added balancer Improvements or additions to the load balancer tests Issues pertaining to tests labels Dec 23, 2023
@dyc3 dyc3 merged commit c42a832 into master Dec 23, 2023
16 of 18 checks passed
@dyc3 dyc3 deleted the balancer-bench branch December 23, 2023 15:56
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
* balancer: add message latency benchmarks

* refactor how balancer context is initialized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balancer Improvements or additions to the load balancer tests Issues pertaining to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant