Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust route_ws_to_correct_monolith to be less flaky #1169

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 7, 2023

No description provided.

@dyc3 dyc3 enabled auto-merge (squash) December 7, 2023 15:17
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a599036) 60.9746% compared to head (c8bb06f) 61.4689%.

❗ Current head c8bb06f differs from pull request most recent head 95bfb65. Consider uploading reports for the commit 95bfb65 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1169        +/-   ##
================================================
+ Coverage   60.9746%   61.4689%   +0.4943%     
================================================
  Files           115        115                
  Lines          9850       9299       -551     
  Branches       1139       1135         -4     
================================================
- Hits           6006       5716       -290     
+ Misses         3844       3583       -261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 7, 2023

1 failed test on run #724 ↗︎

1 60 1 0 Flakiness 0

Details:

Merge c8bb06f into a599036...
Project: OpenTogetherTube Commit: 23cdb5193c ℹ️
Status: Failed Duration: 03:54 💡
Started: Dec 7, 2023 3:18 PM Ended: Dec 7, 2023 3:22 PM
Failed  client/tests/e2e/component/Chat.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video

Review all test suite changes for PR #1169 ↗︎

@dyc3 dyc3 merged commit 149a769 into master Dec 7, 2023
@dyc3 dyc3 deleted the adjust-test branch December 7, 2023 15:32
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant