Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return http status 201 instead of 200 when creating rooms or user accounts #1167

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 7, 2023

No description provided.

Copy link

cypress bot commented Dec 7, 2023

Passing run #722 ↗︎

0 71 1 0 Flakiness 0

Details:

Merge 831ffd6 into a599036...
Project: OpenTogetherTube Commit: 962f636d3d ℹ️
Status: Passed Duration: 03:40 💡
Started: Dec 7, 2023 1:57 PM Ended: Dec 7, 2023 2:01 PM

Review all test suite changes for PR #1167 ↗︎

@dyc3 dyc3 enabled auto-merge (squash) December 7, 2023 15:32
@dyc3 dyc3 disabled auto-merge December 7, 2023 15:35
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a599036) 60.9746% compared to head (305fbe7) 61.6753%.
Report is 1 commits behind head on master.

Files Patch % Lines
server/api/room.ts 50.0000% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1167        +/-   ##
================================================
+ Coverage   60.9746%   61.6753%   +0.7007%     
================================================
  Files           115        115                
  Lines          9850       9550       -300     
  Branches       1139       1147         +8     
================================================
- Hits           6006       5890       -116     
+ Misses         3844       3660       -184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 merged commit 014b0be into master Dec 7, 2023
@dyc3 dyc3 deleted the http-status-codes branch December 7, 2023 15:37
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
…ounts (dyc3#1167)

* return http status 201 instead of 200 when creating rooms or user accounts

* update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant