Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientmanager: add some unit tests #1165

Merged
merged 1 commit into from
Dec 6, 2023
Merged

clientmanager: add some unit tests #1165

merged 1 commit into from
Dec 6, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 6, 2023

No description provided.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (967d3c7) 60.3594% compared to head (8b3c59c) 61.4689%.

Files Patch % Lines
server/clientmanager.ts 44.4444% 5 Missing ⚠️
server/balancer.ts 81.8181% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1165        +/-   ##
================================================
+ Coverage   60.3594%   61.4689%   +1.1094%     
================================================
  Files           115        115                
  Lines          9291       9299         +8     
  Branches       1133       1135         +2     
================================================
+ Hits           5608       5716       +108     
+ Misses         3683       3583       -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 6, 2023

Passing run #720 ↗︎

0 71 1 0 Flakiness 0

Details:

Merge 8b3c59c into 967d3c7...
Project: OpenTogetherTube Commit: 0bc0408bbf ℹ️
Status: Passed Duration: 03:36 💡
Started: Dec 6, 2023 10:11 PM Ended: Dec 6, 2023 10:15 PM

Review all test suite changes for PR #1165 ↗︎

@dyc3 dyc3 merged commit a599036 into master Dec 6, 2023
17 checks passed
@dyc3 dyc3 deleted the client-manager-tests branch December 6, 2023 22:16
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant