balancer: group monoliths by region #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #733 ↗︎
Details:
Review all test suite changes for PR #1157 ↗︎ |
|||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
===========================================
Coverage 61.4689% 61.4689%
===========================================
Files 115 115
Lines 9299 9299
Branches 1135 1135
===========================================
Hits 5716 5716
Misses 3583 3583 ☔ View full report in Codecov by Sentry. |
cjrkoa
approved these changes
Dec 7, 2023
cjrkoa
pushed a commit
to cjrkoa/opentogethertube
that referenced
this pull request
Jan 26, 2024
* add region to `NewMonolith` * add region to `BalancerMonolith` * add and manage monoliths_by_region in `BalancerContext` * update debug endpoint * fix lints * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewMonolithBalancerMonolithmonoliths_by_regioninBalancerContextcloses #1125
Planning to add tests in follow up PRs