Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add region to emulated monolith #1149

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Add region to emulated monolith #1149

merged 7 commits into from
Dec 11, 2023

Conversation

cjrkoa
Copy link
Contributor

@cjrkoa cjrkoa commented Dec 3, 2023

Fixes #1127

@cjrkoa cjrkoa requested a review from dyc3 as a code owner December 3, 2023 19:30
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@c1d2f36). Click here to learn what that means.

❗ Current head adb67ed differs from pull request most recent head 56b06f9. Consider uploading reports for the commit 56b06f9 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             master      #1149   +/-   ##
===========================================
  Coverage          ?   61.4689%           
===========================================
  Files             ?        115           
  Lines             ?       9299           
  Branches          ?       1135           
===========================================
  Hits              ?       5716           
  Misses            ?       3583           
  Partials          ?          0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dyc3
dyc3 requested changes Dec 3, 2023
View reviewed changes
Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MonolithBuilder::build doesn't set the region on the monolith. Also, no unit tests?

crates/harness/src/monolith.rs Show resolved Hide resolved
crates/harness/src/monolith.rs Outdated Show resolved Hide resolved
@cjrkoa cjrkoa requested a review from dyc3 December 3, 2023 20:15
dyc3
dyc3 requested changes Dec 4, 2023
View reviewed changes
crates/harness-tests/src/state.rs Outdated Show resolved Hide resolved
dyc3
dyc3 requested changes Dec 5, 2023
View reviewed changes
crates/harness/src/monolith.rs Outdated Show resolved Hide resolved
dyc3
dyc3 requested changes Dec 7, 2023
View reviewed changes
crates/harness-tests/src/state.rs Outdated Show resolved Hide resolved
crates/harness/src/monolith.rs Outdated Show resolved Hide resolved
@cjrkoa cjrkoa requested a review from dyc3 December 11, 2023 15:29
@dyc3 dyc3 enabled auto-merge (squash) December 11, 2023 15:41
@dyc3 dyc3 merged commit 588bb22 into dyc3:master Dec 11, 2023
9 of 12 checks passed
cjrkoa added a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
@cjrkoa @dyc3
Add region to emulated monolith (dyc3#1149)
23e8b5f 
* Add region to emulated monolith

Fixes dyc3#1127

* requested changes + unit test

* fix emulated region test

* move test

* fix lints

---------

Co-authored-by: Carson McManus <[email protected]>
Co-authored-by: Carson McManus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

harness: add region to emulated monoliths
2 participants
@cjrkoa @dyc3