Skip to content

Conversation

@stdcion
Copy link
Contributor

@stdcion stdcion commented Jun 27, 2022

No description provided.

@stdcion stdcion requested a review from ttldtor June 27, 2022 15:29

void listener(const dxf_snapshot_data_ptr_t snapshot_data, void *user_data) {
size_t i;
size_t records_count = snapshot_data->records_count;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable (records_count) is never used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"-------------------------------------------------------------------------------\n"
"Usage: SnapshotConsoleSample <server address> <event type> <symbol>\n"
" [order_source] [" TIME_PARAM_SHORT_TAG " <DD-MM-YYYY>] "
" [order_source] [" FROM_TIME_PARAM_SHORT_TAG " <DD-MM-YYYY>] [" TO_TIME_PARAM_SHORT_TAG " <DD-MM-YYYY>]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time format does not correspond to the format specified below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

" " TIMEOUT_TAG " <timeout> - Sets the program timeout in seconds (default = 604800,\n"
" i.e a week)\n"
"Example: demo.dxfeed.com:7300 ORDER IBM NTV -t 01-01-1970 -o 30\n\n"
"Example: demo.dxfeed.com:7300 ORDER IBM NTV -from-time 01-01-1970T00:00:00 -o 30\n\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify that user must don't use -from-time -to-time with "indexed only" (indexed but not time series) events (Order, Spread Order, Series).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


#define DATE_TIME_BUF_SIZE 4
/*
* Parse date string in format 'DD-MM-YYYY'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DD-MM-YYYYTHH:mm:ss

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ttldtor ttldtor merged commit 9e20338 into dxFeed:master Jul 1, 2022
ttldtor pushed a commit that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants