Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Elm(ish) Todo List (TodoMVC) Example issue #44 #45

Merged
merged 165 commits into from
Sep 8, 2018

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jul 12, 2018

This will be an end-to-end learning resource so might take me a few days ... ⏳
It will be worth it. πŸ˜‰

@nelsonic nelsonic self-assigned this Jul 12, 2018
@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #45    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           1      4     +3     
  Lines          44    312   +268     
  Branches        0     89    +89     
======================================
+ Hits           44    312   +268
Impacted Files Coverage Ξ”
examples/todo-list/elmish.js 100% <100%> (ΓΈ)
examples/counter-reset-keyboard/counter.js 100% <100%> (ΓΈ)
examples/todo-list/todo-app.js 100% <100%> (ΓΈ)
examples/counter-reset/counter.js 100% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 814467e...ee9c95d. Read the comment docs.

@nelsonic nelsonic temporarily deployed to todomvc-app September 7, 2018 20:01 Inactive
@nelsonic nelsonic temporarily deployed to todomvc-app September 7, 2018 20:25 Inactive
@nelsonic nelsonic temporarily deployed to todomvc-app September 7, 2018 20:29 Inactive
@nelsonic nelsonic temporarily deployed to todomvc-app September 7, 2018 20:34 Inactive
@nelsonic nelsonic temporarily deployed to todomvc-app September 8, 2018 08:11 Inactive
@nelsonic
Copy link
Member Author

nelsonic commented Sep 8, 2018

@iteles I've been through and fixed as many typos and Mardown issues as I could see. πŸ” πŸ“ βœ…
Not going to touch this again until you've had a chance to review it. βœ‹
Thanks for making time. ❀️

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At my current speed, this is going to take me at least a week to review if not two (given existing commitments)!

I have so far only been able to skim it to get the gist and am very excited about this tutorial! But it's MASSIVE.

Seeing as this is a tutorial and is not going to 'break' any 'critical systems' with a merge, I would suggest that I merge this in now and we invite the community as a whole to review it and open issues when there is a question or we run into a block. Many eyes are better than just my 4.

@nelsonic Any objections?

@nelsonic
Copy link
Member Author

nelsonic commented Sep 8, 2018

@iteles agreed. merge and let everyone test it. thanks. πŸ‘

@nelsonic nelsonic assigned iteles and unassigned nelsonic Sep 8, 2018
@iteles iteles merged commit 8ad15df into master Sep 8, 2018
@iteles iteles deleted the elmish-todo-list-issue#44 branch September 8, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants