-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Elm(ish) Todo List (TodoMVC) Example issue #44 #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 4 +3
Lines 44 312 +268
Branches 0 89 +89
======================================
+ Hits 44 312 +268
Continue to review full report at Codecov.
|
@iteles I've been through and fixed as many typos and Mardown issues as I could see. π π β
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At my current speed, this is going to take me at least a week to review if not two (given existing commitments)!
I have so far only been able to skim it to get the gist and am very excited about this tutorial! But it's MASSIVE.
Seeing as this is a tutorial and is not going to 'break' any 'critical systems' with a merge, I would suggest that I merge this in now and we invite the community as a whole to review it and open issues when there is a question or we run into a block. Many eyes are better than just my 4.
@nelsonic Any objections?
@iteles agreed. merge and let everyone test it. thanks. π |
This will be an end-to-end learning resource so might take me a few days ... β³
It will be worth it. π
Elm
(ish) Micro Front-end Framework TDD walkthrough/tutorial!elmish.md
localStorage
Saving / Retrieving Data to/from localStorageΒ #47init
function fromreset-counter
example Do we *need* to "init"?Β #49ADD
Todo itemTOGGLE
state of todo itemdone=true
Toggle All Todo List ItemsΒ #50TOGGLE_ALL
flip the state of all todos at once. Toggle All Todo List ItemsΒ #50[Enter]
keyboard key creates new Todo Item UX Feature Hitting the [Enter] (Return) key creates a new Todo List itemΒ #55onclick=signal(action)
attribute to any element Elm(ish) onClick Event/Function AttributeΒ #58DELETE
a Todo List item DELETE a Todo List item using the "cross" (button)Β #59EDIT
a Todo List Item EDIT an itemΒ #60signal('EDIT', data)
signal('SAVE', data)
ESC
key cancels editing and focus onnew-todo
input [esc] key cancels editing mode (without saving)Β #64