Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define host as hits.dwyl.com #143

Merged
merged 1 commit into from
Feb 16, 2022
Merged

define host as hits.dwyl.com #143

merged 1 commit into from
Feb 16, 2022

Conversation

SimonLab
Copy link
Member

ref: #129

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #143 (8e5530a) into main (863a3ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines           61        61           
=========================================
  Hits            61        61           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863a3ca...8e5530a. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. Should the port be 443? (given that it defaults to HTTPS via Cloudflare)

@nelsonic nelsonic merged commit 6fe81cf into main Feb 16, 2022
@nelsonic nelsonic deleted the fix-webocket-#129 branch February 16, 2022 14:14
@SimonLab
Copy link
Member Author

Yes I wasn't sure about the port and wanted to test the default one first. I'll check the logs once deployed to see if I need to update the port too 👍

@nelsonic
Copy link
Member

Yeah, I thought as much. That's why I merged so you wouldn't have to wait. Hope the exploration is going well. 👍

@SimonLab
Copy link
Member Author

I think I'll need to update also the runtime config:

url: [host: "#{app_name}.fly.dev", port: 80],

@nelsonic
Copy link
Member

Hmm ... could be worth asking on the Fly.io forum e.g: https://community.fly.io/t/phoenix-liveview-hangs-on-websocket-connection-on-all-browsers/3434 to confirm if there's a Doc link we are missing. 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants