Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player is Witcher in Event Notification #97

Closed
TerryDuke opened this issue Jun 16, 2018 · 1 comment
Closed

Player is Witcher in Event Notification #97

TerryDuke opened this issue Jun 16, 2018 · 1 comment
Labels
Milestone

Comments

@TerryDuke
Copy link
Contributor

Repro Steps
To be honest I'm not completely sure of how to reproduce this. You need some monsters to be in your demense, but I do not recall if I already had a Witcher in my court (I think I did), and whether I had sent soldiers or the Witcher (I might have sent the soldiers).

Expected
That after the monsters are cleared out I see a notification event informing me of this, with the text that is "signed" by the Witcher, and with the Witcher's portrait.

Actual
The message is to myself (with my full title) and from myself. In fact it is signed "Witcher Francesca verch Diared Findabair". Also the portrait is blank.

This has happened a couple of times now, but as mentioned I don't recall the setup and so we still need better repro steps.

Notes
The description text is:
EVTDESCmonster.3;Honoured [Root.GetTitledName],\n\nI have taken care of the drowners as you requested.\n\nWitcher [FromFrom.GetFullName];;;;;;;;;;;;;x

This is used in the following event:

# Witcher does its craft
letter_event = {
	id = monster.3
	desc = EVTDESCmonster.3
	
	hide_from = yes
	is_triggered_only = yes
	
	option = {
		name = EVTOPTAmonster.3
		random_demesne_province = {
			limit = { has_province_modifier = drowners }
			remove_province_modifier = drowners
			add_province_modifier = { name = monster_purge duration = 360 hidden = yes }
		}
		wealth = -10
		FROM = { 
			wealth = 10
			add_character_modifier = { name = recent_witcher_work duration = 180 hidden = yes }
		}
	}
}

bug19-witcher-is-empress

@rquinio rquinio added the bug label Apr 1, 2019
@rquinio rquinio added this to the 0.10.1 milestone Apr 1, 2019
@rquinio
Copy link
Collaborator

rquinio commented Apr 1, 2019

Fixed

@rquinio rquinio closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants