Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting Heal (or Druid healing) doesn't cure Lover's Pox #108

Closed
TerryDuke opened this issue Jul 2, 2018 · 1 comment
Closed

Casting Heal (or Druid healing) doesn't cure Lover's Pox #108

TerryDuke opened this issue Jul 2, 2018 · 1 comment
Labels
Milestone

Comments

@TerryDuke
Copy link
Contributor

Repro Steps

  1. Have a character afflicted with Lover's Pox (which is described as Herpes in the vanilla game comments).
  2. Cast Heal on them.

Expected
That the lovers_pox trait be removed, since the description of Heal mentions that it cures illness. It's also listed as an item in the list of triggers for "can_be_healed_by_magic_trigger".

Actual
The character still has Lover's Pox.

Notes
I believe this is caused because Lover's Pox does not have the characteristic "is_illness = yes". It probably should, since it is a disease as per "has_disease_trigger" and "has_minor_disease_trigger" in the vanilla game, and one would describe it as an illness. Regardless, this means that "cure_illness = yes" doesn't remove it, and hence as such just including "cure_illness = yes" in the game effects for casting Heal does not remove Lover's Pox.

@rquinio
Copy link
Collaborator

rquinio commented Jan 19, 2019

I wasn't sure about the impacts of adding is_illness = yes (could break balance of some vanilla events), so I've added the trait in mod healing conditions/effects instead.

@rquinio rquinio closed this as completed Jan 19, 2019
@rquinio rquinio added this to the 0.10.1 milestone Jan 19, 2019
@rquinio rquinio added the bug label Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants