Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing name in "Better Court Mage" #105

Closed
TerryDuke opened this issue Jun 30, 2018 · 3 comments
Closed

Missing name in "Better Court Mage" #105

TerryDuke opened this issue Jun 30, 2018 · 3 comments
Labels
Milestone

Comments

@TerryDuke
Copy link
Contributor

Repro Steps

  1. Have a court mage.
  2. Get another mage in your court that would be a better court mage.
  3. Get the event where the new mage wants to replace the court mage.

Actual
The descriptive text mentions " claims that she would be a better Court Mage than , and petitions". Notice that there is a space after "than".

Expected
That the name of the existing Court Mage appear after the word "than".

Notes
Not sure if this is consistently reproducible. My existing court mage did not have an unusual name as far as I know.

bug22_better-court-mage

@TerryDuke
Copy link
Contributor Author

TerryDuke commented Jul 2, 2018

At first glance it seems okay:

EVTDESCcourt.21;[From.GetBestName] claims that [From.GetSheHe] would be a better Court Mage than [Root.job_mage.GetTitledFirstName], and petitions that [From.GetSheHe] should be given the title of Court Mage of the [Root.PrimaryTitle.GetFullName].;;;;;;;;;;;;;x

compared with

EVTDESCcourt.71;[From.GetBestName] claims that [From.GetSheHe] would be a better Steward than [Root.job_treasurer.GetTitledFirstName], and petitions that [From.GetSheHe] should be given the title of Steward of the [Root.PrimaryTitle.GetFullName].;;;;;;;;;;;;;x

The variable "job_mage" seems defined the same way as job_chancellor and the others, as well. Will keep looking. Perhaps the problem actually lies in GetTitledFirstName for the title "Court Magician" (defined with the variable "job_mage" as well).

@rquinio
Copy link
Collaborator

rquinio commented Jul 16, 2018

Hmm, it would actually makes sense that [.job_mage.] scope doesn't work in localization commands, since it's a new job title and localization scopes are probably hardcoded to vanilla ones.

A solution could be to rework the event with some additional ping events so that job_mage is in [FromFrom] ?

@rquinio rquinio added the bug label Apr 1, 2019
@rquinio rquinio added this to the 0.10.1 milestone Apr 1, 2019
rquinio added a commit that referenced this issue Apr 1, 2019
@rquinio
Copy link
Collaborator

rquinio commented Apr 1, 2019

I've reworked the localization text to avoid direct usage of job_mage.

@rquinio rquinio closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants