fix: correct build pipeline

.github/workflows/pull-request.yaml

@@ -10,15 +10,15 @@ jobs:
     - name: Checkout
       uses: actions/checkout@v2
 
-    # Check typescript compiles properly.
-    - name: Check TypeScript
-      run: make typescript-check
-
     # Fixup Git URLs, see:
     # https://stackoverflow.com/questions/70663523/the-unauthenticated-git-protocol-on-port-9418-is-no-longer-supported
     - name: Fix up git URLs
       run: echo -e '[url "https://github.com/"]\n  insteadOf = "git://github.com/"' >> ~/.gitconfig
 
+    # Check typescript compiles properly.
+    - name: Check TypeScript
+      run: make typescript-check
+
     # Run the build - this will fail if there are broken links etc.
     - name: Build
       run: make build

.github/workflows/release-please.yaml

@@ -36,6 +36,11 @@ jobs:
         run: echo -e '[url "https://github.com/"]\n  insteadOf = "git://github.com/"' >> ~/.gitconfig
         if: ${{ steps.release.outputs.release_created }}
 
+      # Check typescript compiles properly.
+      - name: Check TypeScript
+        run: make typescript-check
+        if: ${{ steps.release.outputs.release_created }}
+
       # Run the build - this will fail if there are broken links etc.
       - name: Build
         run: make build

makefile

@@ -21,7 +21,6 @@ typescript-check:
 # folder as if we don't have them we should definitely not deploy.
 .PHONY: build
 build:
-	npx tsc # test for typescript types...
 	mkdir -p ./static/downloads
 	./scripts/build-samples.sh
 	cp ./artifacts/samples.zip  ./static/downloads/effective-shell-samples.zip