Conversation
Owner
Author
|
Going to close/open to see if I can get travis to trigger |
Owner
Author
|
Summary of what's in here:
Also, I migrated us to travis-ci.com (from the .org). There's a general (but very gentle) push from the Travis folks to go that direction. As a thought for the future, it might make sense for testing against MDTraj master to be skipped on the |
sroet
requested changes
Jun 30, 2020
Collaborator
sroet
left a comment
There was a problem hiding this comment.
1 question, 1 proposed change (feel free to ignore), and some commented out leftover code, looks good to me otherwise
This was referenced Jul 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our Travis script has a Py27/MDTraj dev test job. However, MDTraj has made changes that are incompatible with Py27. We'd already discussed dropping Py27 and Win32 from tests (#69 (comment)), so I'm doing it now.
While I'm at it, I'm including Py38 in our test matrix (overdue!). Note that the next release will be the last one to guarantee support Python 3.6 (by NEP29 we could already drop 3.6, but I'm going to take a slightly more conservative approach.)