Added test for non_periodic systems#65
Merged
dwhswenson merged 1 commit intodwhswenson:masterfrom Nov 18, 2019
Merged
Conversation
Owner
|
LGTM, and passes when re-running after the merge of #64. On some of the style changes -- I usually prefer extra indentation when using backslash continuation. PEP8 doesn't have an opinion on this, but suggests extra indentation as one option. I think this may be one of the areas where I differ from |
dwhswenson
approved these changes
Nov 18, 2019
This was referenced Jan 31, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an unittest for the failing behavior described by #64
Fails on current master before that MR was merged, passes on that branch, should pass on the current master
(Also does some minor pep8 fixes)