Conversation
sroet
left a comment
There was a problem hiding this comment.
point 1: agreed and could not come up with a better name so far
point 2: No debate from me ;-)
point 3: No issues (grep -lr "2018" did trigger on examples/data/gsk3b_example.h5, but I suspect that is a random hit on the binary)
Couple points:
From a quick grep -lr "David" on this branch:
setup.py has only your name as the author= variable
contact_map/contact_map still has your name only in the block comment at the start of the file
From a grep -lr "contact_map\`"
we still have a contact_map reference in docs/installing.rst which we might or might not change (no strong preference from me)
LGTM otherwise
|
I had intentionally left I'll add that, following the example at https://packaging.python.org/specifications/core-metadata/#author-email. Which email address should I use for you? |
Yeah, I think in that case it is referring to the package name. Technically, I think our recommended style is:
Granted, I'm sure that I'll mix up those two terms all the time (calling it the "Contact Map Explorer package"), but when it doubt, that's the guideline to use. |
|
Please use my hotmail (as that one is linked to github) |
|
@sroet : |
Perfect, last requested change left is about the block comment at the start of |
Sorry, overlooked that. I removed those lines. They date back to when this was a gist. Now author and license info should come from |
This PR does 3 things:
Rename everything to "Contact Map Explorer". Here are my reasons for that:
contact_mapand when to call it "Contact Map" or "Contact Maps", and in general how to refer to it ("thecontact_mappackage` feels clumsy compared to a proper noun.)I'm open to argument or suggestion for better names.
Promotes @sroet to co-author, as is appropriate to his contributions. I'm much less open to debate on this. Sorry Sander, you're stuck with it ;-) For things that are single-maintainer, I keep that role, but I intend to add Sander as co-maintainer where possible (e.g., conda-forge), starting with the next release.
Bumps copyright year. That's definitely not objectionable.
I think I fixed everything relevant to these points, but it is possible that project name/authorship/copyright is hiding somewhere I haven't seen. We'll update if I missed things.