Merged
Conversation
Owner
|
LGTM. Merging. (We might consider dropping/changing the comments on |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an discrepancy between
DaskFrequencyand it's parent class (ContactMap)__init__(), we tried to convert indices back to unsliced two times:DaskFrequencycalls thesuper.__init__:ContactFrequency.__init__()converts to sliced indices, calls_build_contact_mapand converts back to real indicesHowever
DaskFrequency._build_contact_mapconstructs newContactFrequencyobjects and sums them (in unsliced indices), so after this theContactFrequency.__init__()tries to convert these already correct indices back again.In order to solve this I moved the conversion from sliced to regular indices as part of the
_build_contact_maproutine ofContactFrequency.fixes #51