-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for querying Global Secondary Indexes which have no range… #36
Conversation
… element to them.
Ok, I've worked out the command to run the it test now: awsWrapTest/it:test |
Thanks for this, just ran into the same missing functionality, hope this gets merged soon! |
@glidester, thanks a lot for your pull request. I’m sorry that it’s taken so long for me to get back to you. I just set your a PR to add to this one: glidester#1 |
|
||
val keyConditions: Seq[(String, Condition)] = | ||
Seq((hashAttributeName, QueryCondition.equalTo(hashValue))) ++ | ||
rangeCondition.map( Seq(_) ).getOrElse(Seq.empty[(String, Condition)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be more neatly done as something like:
val keyConditions = {
val b = Map.newBuilder[String, Condition]
b += (hashAttributeName -> QueryCondition.equalTo(hashValue))
rangeCondition.foreach(b += _)
b.result()
}
@glidester, You’ve added the right stuff to |
add integration test for DyDB global secondary index
…daryIndex functionality to QueryOnceMagnet trait.
Hi @dwhjames, thanks for the feed back. I've made the change that you suggested and added Thanks |
👍 FYI, I’m going to merge this and release as |
Add support for querying Global Secondary Indexes which have no range…
released in v0.7.3 |
Could not see a way of querying global secondary indexes so I have created a new method queryOnGlobalSecondaryIndex that allows you to specify the index name, attribute name and an optional range condition.
As an aside can I ask how you run the integration tests from sbt? I can't seem to figure it out.
Thanks