Improved implementation for FutureTransfer.listenFor #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast to internal type `AbstractTransfer` so that a low-level state change listener can be attached. In light of issue #30, this provides a more foolproof implementation of listening to transfer events. There is now a three-way race to complete the promise that signals the completion/termination of the transfer. This adds an integration test for s3, using the fakes3 ruby gem. closes #30
dwhjames
added a commit
that referenced
this pull request
Apr 22, 2015
Improved implementation for FutureTransfer.listenFor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast to internal type
AbstractTransferso that alow-level state change listener can be attached.
In light of issue #30, this provides a more foolproof
implementation of listening to transfer events.
There is now a three-way race to complete the
promise that signals the completion/termination of
the transfer.
This adds an integration test for s3, using the
fakes3 ruby gem.
closes #30